Add sparkle motion #819
Merged
Add sparkle motion #819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentru
requested changes
Sep 26, 2025
src/Wippersnapper.h
Outdated
| extern Wippersnapper WS; ///< Global member variable for callbacks | ||
|
|
||
| #endif // ADAFRUIT_WIPPERSNAPPER_H | ||
| /*! |
There was a problem hiding this comment.
Why is there a diff on this file?
There was a problem hiding this comment.
Bloody github web editor, my bad (for using it). It changes all the line endings sometimes, along with adding a newline at the end if it miss-understands the EOF/line-endings.
They suggested we add a .gitattributes file with config options for the repo, but I don't like the idea of forcing all text files to one of CRLF or LF, they have raised an issue internally as it used to work.
I will make a mental note and add a post it note about not using the web editor to my screen.
tyeth
force-pushed
the
add-sparkle-motion
branch
from
6be4cfc to
96a2277
Compare
tyeth
force-pushed
the
add-sparkle-motion
branch
from
96a2277 to
7d1474d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Full Fat Sparkle Motion